Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support regional compilation #1618

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chaojun-zhang
Copy link
Contributor

What does this PR do?

DeepSpeed's addition of forward and backward hooks to the model causes torch dynamo to fall back to eager mode during compilation for the backward pass (e.g., using CppTensorPreHookFunction), leading to a significant performance degradation.

By applying regional compilation to the model, we can effectively isolate DeepSpeed's hooks from the backward graph, allowing dynamo to successfully trace the backward pass of the model, thus improving performance.

More info about regional compilation:

https://pytorch.org/tutorials/recipes/regional_compilation.html
https://pytorch.org/blog/pytorch2-5/

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@chaojun-zhang
Copy link
Contributor Author

@regisss can you have a look ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant