Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the inline_inbuilt_nn_modules option #1617

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add the inline_inbuilt_nn_modules option #1617

wants to merge 1 commit into from

Conversation

chaojun-zhang
Copy link
Contributor

@chaojun-zhang chaojun-zhang commented Dec 17, 2024 •
edited
Loading

Disabling the inline_inbuilt_nn_modules switch will restore ALBERT-XXL's performance to PyTorch 2.4 levels

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@chaojun-zhang chaojun-zhang marked this pull request as draft December 17, 2024 01:20
@chaojun-zhang
In PyTorch 2.5, inline_inbuilt_nn_module was enabled by default, lead…
4c1b7f8 
…ing to performance degradation in certain models（e.g. ALBERT_XXL）. A configuration option has been introduced to turn off this behavior
@chaojun-zhang chaojun-zhang marked this pull request as ready for review December 17, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regisss regisss Awaiting requested review from regisss regisss is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chaojun-zhang