Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use get_chat_template() instead of default_chat_template #197

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

alvarobartt
Copy link
Member

Description

This PR updates the get_tokenizer function so that the default chat template is checked using the get_chat_template method instead of the default_chat_template attribute as it's not available.

@alvarobartt alvarobartt added the bug Something isn't working label Aug 19, 2024
@alvarobartt alvarobartt self-assigned this Aug 19, 2024
Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@lewtun lewtun merged commit 28bf902 into main Aug 19, 2024
2 of 3 checks passed
@lewtun lewtun deleted the use-get-chat-template branch August 19, 2024 08:12
dmilcevski pushed a commit to dmilcevski/alignment-handbook that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants