Skip to content

Commit

Permalink
Merge pull request #1 from huggingface/doc-builder
Browse files Browse the repository at this point in the history
Doc builder testing PR
  • Loading branch information
natolambert authored Sep 1, 2023
2 parents 8903d4a + d2fed11 commit 8ae7039
Show file tree
Hide file tree
Showing 9 changed files with 94 additions and 2 deletions.
20 changes: 20 additions & 0 deletions .github/workflows/build_documentation.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: Build documentation

on:
push:
branches:
- main

jobs:
build:
uses: huggingface/doc-builder/.github/workflows/build_main_documentation.yml@main
with:
commit_sha: ${{ github.sha }}
package: rlhf-handbook
# package_name: rlhf-handbook # commented from audio-course
path_to_docs: rlhf-handbook/chapters/
additional_args: --not_python_module
languages: en
secrets:
token: ${{ secrets.HUGGINGFACE_PUSH }}
hf_token: ${{ secrets.HF_DOC_BUILD_PUSH }}
19 changes: 19 additions & 0 deletions .github/workflows/build_pr_documentation.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: Build PR Documentation

on:
pull_request:

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

jobs:
build:
uses: huggingface/doc-builder/.github/workflows/build_pr_documentation.yml@main
with:
commit_sha: ${{ github.event.pull_request.head.sha }}
pr_number: ${{ github.event.number }}
package: rlhf-handbook
path_to_docs: rlhf-handbook/chapters/
additional_args: --not_python_module
languages: en
12 changes: 12 additions & 0 deletions .github/workflows/delete_doc_comment_trigger.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
name: Delete doc comment trigger

on:
pull_request:
types: [ closed ]


jobs:
delete:
uses: huggingface/doc-builder/.github/workflows/delete_doc_comment_trigger.yml@main
with:
pr_number: ${{ github.event.number }}
16 changes: 16 additions & 0 deletions .github/workflows/upload_pr_documentation.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: Upload PR Documentation

on:
workflow_run:
workflows: ["Build PR Documentation"]
types:
- completed

jobs:
build:
uses: huggingface/doc-builder/.github/workflows/upload_pr_documentation.yml@main
with:
package_name: rlhf-handbook
secrets:
hf_token: ${{ secrets.HF_DOC_BUILD_PUSH }}
comment_bot_token: ${{ secrets.COMMENT_BOT_TOKEN }}
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -157,4 +157,4 @@ cython_debug/
# be found at https://github.com/github/gitignore/blob/main/Global/JetBrains.gitignore
# and can be added to the global gitignore or merged into this file. For a more nuclear
# option (not recommended) you can uncomment the following to ignore the entire idea folder.
#.idea/
.idea/
17 changes: 17 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,20 @@
# The RLHF Handbook

Robust recipes for RLHF

## Developing
To view this locally, run the following (need to point to a specific language if previewing only one section, preview/`build_doc` does not use the `--language` flag):
```shell
doc-builder preview rlhf-handbook {docs_dir} --not_python_module
```
Example `docs_dir` is `~/Documents/HuggingFace/dev/rlhf-handbook/chapters/en`

## Installation
Create a new conda environment with:
```shell
conda create -n rlhf-handbook python=3.10
```
Install the limited requirements with
```shell
pip install -r requirements.txt
```
4 changes: 4 additions & 0 deletions chapters/en/_toctree.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- title: Unit 0. Welcome to the course!
sections:
- local: chapter0/introduction
title: What to expect from the course
3 changes: 2 additions & 1 deletion chapters/en/chapter0/introduction.mdx
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
# Welcome to the RLHF Handbook!
# Welcome to the RLHF Handbook!
We are going to...
3 changes: 3 additions & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
hf-doc-builder>=0.4.0
black>=23.3.0
watchdog>=3.0.0

0 comments on commit 8ae7039

Please sign in to comment.