upgrade react version to 18 #BLT-1231 #BLT-1232 #2939
+7,110
−5,725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iru89
force-pushed
the
botonic-react/react-18
branch
from
27fe174
to
29162b9
Compare
vanbasten17
reviewed
Nov 17, 2024
vanbasten17
reviewed
Nov 17, 2024
vanbasten17
approved these changes
Nov 17, 2024
Iru89
changed the title
Iru89
changed the title
AlbertGom
reviewed
Nov 18, 2024
There was a problem hiding this comment.
The changes look good to me 🎉! However, I just wanted to check if you’ve considered some of the new behaviors introduced with createRoot in React 18, for example the concurrent rendering, which could impact how state updates or renders are managed.
Also, I’d recommend enabling Strict Mode if it’s not already in use. Could be helpful in finding potential issues, especially with the updated lifecycle behaviors in React 18.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@botonic/react
@testing-library/react-hooksdependency and importrenderHookandactfrom `"@testing-library/react``@botonic/plugin-flow-builder
Published 0.31.0-alpha.2 versions for @botonic/react and @botonic/plugin-flow-builder
Testing
Fix some test