Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

botonic-react: fix cover component in botonic react #BLT-1223 #2938

Open
wants to merge 6 commits into
base: master-lts
Choose a base branch
from

Conversation

Iru89
Copy link
Contributor

@Iru89 Iru89 commented Nov 14, 2024

Description

Create a separate file for the cover component (using typescript and reducing the size of the webchat file).
Add the toggleCoverComponent function in the WebchatContext to avoid having to pass the function using props

Context

Removing the scroll in a previous PR was not rendering the cover component correctly

Approach taken / Explain the design

Use a conditional render to render the cover component or the webchat. It is not necessary to render the messages under the cover component.

@Iru89 Iru89 changed the title Blt 1223 fix cover component in botonic react botonic-react: fix cover component in botonic react #BLT-1223 Nov 14, 2024
@Iru89 Iru89 marked this pull request as ready for review November 14, 2024 17:09
Copy link
Contributor

@vanbasten17 vanbasten17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice it is a starting point for having this in TS, I think we can still improve it in next iterations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants