move MockAdapter into hubot repository #1348
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation of #1347. Having the declaration of
MockAdapter
inside the Hubot repository makes sense anyway, it is fairly simple and we depend on it in our tests, so we should have full control. The main problem is thathubot-mock-adapter
doesrequire('hubot/src/adapter')
which I don’t think is officially supported, it should berequire('hubot').Adapter
instead.If we want to keep a
hubot-mock-adapter
we should bring it up to date (e.g. it referssrc/scripts
in the README.md which doesn’t exist) and move it to the hubotio GitHub organization.In #1347 we want to convert the tests independent of the source files, and the changes in this PR became necessary for the tests to still pass after converting all
/src/*
files to JavaScript.