Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include triggering actor in workflow run #2006

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

HerrDerb
Copy link
Contributor

@HerrDerb HerrDerb commented Jan 8, 2025

Description

Adds triggeringActor to GHWorkflowRun
See response object -> https://docs.github.com/en/rest/actions/workflow-runs?apiVersion=2022-11-28#list-workflow-runs-for-a-repository

Being able to display the trigger actor, allows a faster identification of the desired workflow run

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@HerrDerb HerrDerb force-pushed the triggering-actor-workflow-run branch 2 times, most recently from 1511f8c to e81a6f2 Compare January 8, 2025 20:18
@HerrDerb HerrDerb force-pushed the triggering-actor-workflow-run branch from e81a6f2 to a64c06b Compare January 8, 2025 20:19
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.26%. Comparing base (c8f4815) to head (a64c06b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2006   +/-   ##
=========================================
  Coverage     83.26%   83.26%           
- Complexity     2354     2355    +1     
=========================================
  Files           233      233           
  Lines          7229     7230    +1     
  Branches        379      379           
=========================================
+ Hits           6019     6020    +1     
  Misses          973      973           
  Partials        237      237           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwiseman bitwiseman merged commit 8714d1b into hub4j:main Jan 9, 2025
12 checks passed
@bitwiseman
Copy link
Member

Thanks!

@HerrDerb HerrDerb deleted the triggering-actor-workflow-run branch January 10, 2025 10:30
@HerrDerb
Copy link
Contributor Author

@bitwiseman what is your release scheduel?

@bitwiseman
Copy link
Member

I'll get a release out this week.

@HerrDerb
Copy link
Contributor Author

Cool, thank you 💐🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants