Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not using
path
in cookies can lead to unexpected behaviors as you may land with the same cookie name but different paths. Updated the example to always usepath
.Another option would be default the
path
to/
but not sure if this would cause security issues. .NET does exactly what tide is currently doing. I personally believe there shouldn't be an api to only set name and value for a cookie without domain and path but that is for another discussion. These days I tend to say never to use framework apis for cookies but instead always use the wrapper so it is done in a safe way.Also updated the example to handle when cookie is not present as the first time I ran it my initial impression was cookie example was broken since
.unwrap()
was causing crash.