Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add connection_cache_size to Config #96

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fiag
Copy link

@fiag fiag commented Aug 25, 2021

Add a feature, to set connection_cache_size opt.

Copy link
Member

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At minimum this also need to be implemented for the `async-h1 client, since that will become the default in 3.0.

The docs should also state which other clients this does and doesn't have an effect on (ideally we try to apply it to as many as possible).

@fiag
Copy link
Author

fiag commented Aug 30, 2021

Is there any clue to add the connection cache for the async-h1 client?

@Fishrock123
Copy link
Member

You'll need to figure out how to implement it for the async-h1 client. You might need an atomic counter of some sort on the client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants