Модуляция #4
Merged
Модуляция #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Генерация данных
MaxOrel
reviewed
Jan 19, 2025
| @@ -0,0 +1,48 @@ | |||
| import {getRandomNumber} from './getRandomNumber'; | |||
|
|
|||
| const messages = [ | |||
There was a problem hiding this comment.
Название констант таких называй в верхнем регистре разделяя их нижним подчеркиванием
MESSAGES NAMES PHOTOS_DESCRIPTIONS
MaxOrel
reviewed
Jan 19, 2025
| function getOneComment(i) { | ||
| const oneComment = {}; | ||
|
|
||
| oneComment.id = getRandomNumber(i * 10 + 1, (i + 1) * 10); |
There was a problem hiding this comment.
Магические числа, такие как 10, 6, 2 нужно выносить в константы и давать им имя, чтобы было понятно почему именно они, разработчик который в будущем будет смотреть код не будет знать о техническом задании для этой задачи и ему нужно показать так контекст
MaxOrel
approved these changes
Jan 19, 2025
| export function getComments () { | ||
| const comments = []; | ||
|
|
||
| const maxComments = getRandomNumber(0,30); |
| export function getPhotos() { | ||
| const photos = []; | ||
|
|
||
| for(let i = 0; i < 25; i++){ |
| onePhoto.id = i + 1; | ||
| onePhoto.url = `photos/${onePhoto.id}.jpg`; | ||
| onePhoto.description = photosDescriptions[i]; | ||
| onePhoto.likes = getRandomNumber(15,200); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎓 Модуляция