Открывается и закрывается (часть 2) #9
Merged
+66
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keksobot
changed the title
bellavin
reviewed
Jan 16, 2025
js/comments-viewer.js
Outdated
| currentCommentsLoaded++; | ||
| updateCommentCounters(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Удали функцию и применяй вместо нее одну строку с classList.toggle
Подробнее можешь почитать в статье https://gomakethings.com/the-mysterious-second-argument-on-the-vanilla-js-classlist.toggle-method/
js/comments-viewer.js
Outdated
| socialCommentsElement.appendChild(newCommentElement); | ||
| } | ||
|
|
||
| function updateCommentCounters() { |
There was a problem hiding this comment.
Удали функцию и вынеси две строчки внутрь addCommentAndUpdateCounter
js/comments-viewer.js
Outdated
| updateLoadCommentsButtonVisibility(); | ||
| } | ||
|
|
||
| function addComment(comment) { |
There was a problem hiding this comment.
function addComment({avatar, name, commentsList}) {
bellavin
reviewed
Jan 17, 2025
js/comments-viewer.js
Outdated
| const currentCommentsCountElement = bigPictureElement.querySelector('.social__comment-shown-count'); | ||
| const totalCommentsCountElement = bigPictureElement.querySelector('.social__comment-total-count'); | ||
| const loadCommentsButtonElement = bigPictureElement.querySelector('.social__comments-loader'); | ||
| const loadingStep = 5; |
There was a problem hiding this comment.
Оформи как константу плиз
| const totalCommentsCountElement = bigPictureElement.querySelector('.social__comment-total-count'); | ||
| const loadCommentsButtonElement = bigPictureElement.querySelector('.social__comments-loader'); | ||
| const loadingStep = 5; | ||
| let commentsArray = []; |
There was a problem hiding this comment.
У массива не let, а const
js/comments-viewer.js
Outdated
| loadCommentsButtonElement.classList.toggle('hidden', currentCommentsLoaded >= totalComments); | ||
| } | ||
|
|
||
| function addComment({avatar, name, commentsList}) { |
There was a problem hiding this comment.
addComment можно вообще вынести в отдельный файл и обозвать например renderComment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎓 Открывается и закрывается (часть 2)