Надо подкачаться #11
Merged
Надо подкачаться #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keksobot
changed the title
bellavin
reviewed
Jan 20, 2025
js/photo-edit-modal.js
Outdated
| const hashtagInputElement = formElement.querySelector('.text__hashtags'); | ||
| const descriptionInputElement = formElement.querySelector('.text__description'); | ||
|
|
||
| const clearForm = () => { |
There was a problem hiding this comment.
Вместо clearForm сбрасывай просто методом .reset() у формы
bellavin
reviewed
Jan 20, 2025
js/api.js
Outdated
| import { cloneElement } from './utils.js'; | ||
|
|
||
| const getData = () => { | ||
| return fetch('https://31.javascript.htmlacademy.pro/kekstagram/data') |
There was a problem hiding this comment.
URL нужно вынести в константу
js/api.js
Outdated
| cloneElement(errorTemplateElement); | ||
| setTimeout(() => { | ||
| document.querySelector('.data-error').classList.add('hidden'); | ||
| }, 5000); |
There was a problem hiding this comment.
Таймаут нужно вынести в константу
| import { closeModal, onEscapeDown } from './photo-edit-modal.js'; | ||
| import { pristine } from './photo-edit-form-validation.js'; | ||
| import { cloneElement } from './utils.js'; | ||
|
|
There was a problem hiding this comment.
Для getData и sendData нужно создать функцию с общей логикой
js/api.js
Outdated
| submitButtonElement.disabled = true; | ||
|
|
||
| fetch( | ||
| 'https://31.javascript.htmlacademy.pro/kekstagram', |
There was a problem hiding this comment.
'https://31.javascript.htmlacademy.pro/kekstagram' нужно вынести в константу
js/api.js
Outdated
|
|
||
| if (pristine.validate()) { | ||
| const formData = new FormData(evt.target); | ||
| submitButtonElement.disabled = true; |
There was a problem hiding this comment.
submitButtonElement.disabled = true; -> submitButtonElement.setAttribute('disabled', 'true');
js/api.js
Outdated
| fetch( | ||
| 'https://31.javascript.htmlacademy.pro/kekstagram', | ||
| { | ||
| method: 'POST', |
There was a problem hiding this comment.
Для методов GET и POST нужно сделать перечисление
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎓 Надо подкачаться