typecheck - remove spread args #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbieTheWagner
requested changes
Mar 17, 2018
addon/mixins/touch-action.js
Outdated
| @@ -41,7 +41,7 @@ export default Mixin.create({ | |||
| ignoreTouchAction: false, | |||
|
|
|||
| init() { | |||
| this._super(...arguments); | |||
There was a problem hiding this comment.
I'm still not sure why we don't want this. ember recommends we do this in all hooks, so I think we should leave it.
There was a problem hiding this comment.
Updated.
FWIW it is a possible perf hit simply because of the babel transpilation. I tried measuring the differences in a dummy app with 200+ components to see if it made a difference and the results were pretty much the same.
sbatson5
force-pushed
the
typecheck-remove-spread-args
branch
from
9558c83
to
a42c932
Compare
RobbieTheWagner
approved these changes
Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per comments from @eriktrom on #52. Updating the typecheck and getting rid of the spread args.