Use native TLS only, don't mix it with rustls (2nd try) #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reqwest uses native TLS, but rspotify with ureq currently uses rustls, i.e. ncspot bundles rustls and is linked with system TLS library at the same time. This has already been fixed in 80da5a8, but this commit has been reverted in aeff120 due to a bug in rspotify that was fixed in 0.13.1 (ramsayleung/rspotify#471).
|
Thanks for taking care! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reqwest uses native TLS, but rspotify with ureq currently uses rustls, i.e. ncspot bundles rustls and is linked with the system TLS library at the same time.
This has already been fixed in 80da5a8, but this commit has been reverted in aeff120 due to a bug in rspotify that was fixed in 0.13.1 (ramsayleung/rspotify#471).
This time I properly tested that it works correctly.
Related to #1159 #1153