fix mem leak from groups array

hrgdavor · Sep 14, 2024 · 9da7ddf · 9da7ddf
1 parent 2038007
commit 9da7ddf
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/packages/render-threejs/index.js b/packages/render-threejs/index.js
@@ -31,7 +31,7 @@ export function RenderThreejs({
   let renderTimer
   let meshColor = new Color(1, 1, 1)
 
-  const entities = []
+  let entities = []
   const groups = []
   let canvas
 
@@ -202,10 +202,12 @@ export function RenderThreejs({
     groups.forEach(group => {
       _scene.remove(group)
     })
-    entities.forEach(ent => {
-      if (ent.geometry) ent.geometry.dispose()
-    })
-    entities.length = 0
+    let old = entities
+    entities = []
+    groups.length = 0
+    setTimeout(()=>{
+      old.forEach(ent => ent.geometry?.dispose?.())
+    },0)
     scene.items.forEach(item => {
       const group = new Group()
       groups.push(group)