-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UTF16 and Conhost support for Windows #175
Conversation
|
Also moved the safe_WriteConsoles to the conhost.c file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good overall. My main requests are that we leave the UTF-16 switch/WriteConsoleW()
code out for now and focus on the direct Conhost output, plus a raft of small stylistic changes.
Thanks a lot for doing this!
this adds 2 new options
--utf16
output using WriteConsoleW--format conhost
use Legacy Windows Console API (implies --utf16)