Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable more pylint #235

Merged
merged 3 commits into from
Nov 16, 2023
Merged

enable more pylint #235

merged 3 commits into from
Nov 16, 2023

Conversation

wdpypere
Copy link
Contributor

These are the main pylint tests which flag "old school" coding style from before python 3.6.

  • I'm a bit hesitant to enable consider-using-fstring because it's a lot. I cleaned out a lot of projects already but still.
  • super-with-arguments: was for python 2
  • useless-object-inheritance: same, no need to add it anymore
  • unidiomatic-typecheck: use isinstance(var, type) instead of if type(var) == type
  • unnecessary-pass: if an empty function or class has a docstring, a pass is not needed.

This PR will fail it's own tests, needs #234

opinions?

@stdweird stdweird merged commit 418803f into hpcugent:master Nov 16, 2023
3 checks passed
@wdpypere wdpypere deleted the enable_more_pylint branch November 17, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants