-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add py39 to tox tests #216
Conversation
* newstack: (27 commits) add a workable test stack for python 3.9 fix methodinspector fix testing some pylint fixes bump version shared_setup: tests: at least print the original TypeError, sometimes it has nothing to do with patterns fix test add python-ldap to PYTHON_BDIST_RPM_PREFIX_MAP restrict zipp to py3.6 compatible version remove comment about tox version from github action cap versions of tox and virtualenv in github action pin versions of virtualenv and tox compatible with Python v3.6 in the test environment Fix error in case of installing with pip and pyproject.toml add missing dep restore old pylint hack make README reflect reality make pip3 default over easy_install remove python 2 way of installing tox version bump remove deprecated vsc-ci options ...
@@ -146,8 +146,8 @@ def gen_tox_ini(): | |||
envs = [] | |||
|
|||
# always run tests with Python 3 | |||
py3_env = 'py36' | |||
envs.append(py3_env) | |||
py3_envs = ['py36', 'py39'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do we run tests without 39 in certain repos?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add it to vsc-cfg.ini
to optionally disable it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be a good idea, same way we did it for the py3 move.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look into it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, should be dealt with same as in py3 move: first it's opt in, then mandatory with optout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I'll get something working
I will revamp this one when #229 is merged |
@@ -107,6 +107,9 @@ | |||
EXPECTED_TOX_INI_PY36_IGNORE = """ | |||
[testenv:py36] | |||
ignore_outcome = true | |||
|
|||
[testenv:py39] | |||
ignore_outcome = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this does not work right? the outcomes are not ignored
* origin/master: bump versions a lot more
superseded by #230 |
Let's be future proof and start testing python 3.9 also?