add py39 to tox tests #216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdpypere
reviewed
Oct 24, 2023
* newstack: (27 commits) add a workable test stack for python 3.9 fix methodinspector fix testing some pylint fixes bump version shared_setup: tests: at least print the original TypeError, sometimes it has nothing to do with patterns fix test add python-ldap to PYTHON_BDIST_RPM_PREFIX_MAP restrict zipp to py3.6 compatible version remove comment about tox version from github action cap versions of tox and virtualenv in github action pin versions of virtualenv and tox compatible with Python v3.6 in the test environment Fix error in case of installing with pip and pyproject.toml add missing dep restore old pylint hack make README reflect reality make pip3 default over easy_install remove python 2 way of installing tox version bump remove deprecated vsc-ci options ...
stdweird
reviewed
Oct 25, 2023
| @@ -146,8 +146,8 @@ def gen_tox_ini(): | |||
| envs = [] | |||
|
|
|||
| # always run tests with Python 3 | |||
| py3_env = 'py36' | |||
| envs.append(py3_env) | |||
| py3_envs = ['py36', 'py39'] | |||
There was a problem hiding this comment.
how do we run tests without 39 in certain repos?
There was a problem hiding this comment.
We can add it to vsc-cfg.ini to optionally disable it?
There was a problem hiding this comment.
might be a good idea, same way we did it for the py3 move.
There was a problem hiding this comment.
yes, should be dealt with same as in py3 move: first it's opt in, then mandatory with optout
There was a problem hiding this comment.
OK, I'll get something working
|
I will revamp this one when #229 is merged |
wdpypere
reviewed
Oct 25, 2023
| @@ -107,6 +107,9 @@ | |||
| EXPECTED_TOX_INI_PY36_IGNORE = """ | |||
| [testenv:py36] | |||
| ignore_outcome = true | |||
|
|
|||
| [testenv:py39] | |||
| ignore_outcome = true | |||
There was a problem hiding this comment.
this does not work right? the outcomes are not ignored
* origin/master: bump versions a lot more
|
superseded by #230 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's be future proof and start testing python 3.9 also?