Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTF2 reader using core reader #143

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

OTF2 reader using core reader #143

wants to merge 14 commits into from

Conversation

zoreoo
Copy link
Collaborator

@zoreoo zoreoo commented Nov 4, 2024

Basically ready for review. A few notes:

  1. The original OTF2 reader added everything into a list (and a dictionary for metrics) and then created a DataFrame based on those lists. With the core reader implementation, I changed everything so that each event is added to the core reader as each event is visited.
  2. There may now be metric columns with all NaN data, as opposed to the past implementation that avoided it. I will see what I can do with this.
  3. Metrics were a bit tricky, so I hope I didn't mess anything up there.
  4. When initializing the core reader, I was not 100% confident in what I put for the start and stride values--but we can look at this.
  5. I will need to update comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants