Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-33066 add more ECL Watch v9 UI tests #19366

Open
wants to merge 1 commit into
base: candidate-9.2.x
Choose a base branch
from
Open

HPCC-33066 add more ECL Watch v9 UI tests #19366

wants to merge 1 commit into from

Conversation

jeclrsg
Copy link
Contributor

@jeclrsg jeclrsg commented Dec 17, 2024

add a few more ECL Watch v9 playwright tests, mostly on the WU, File and Query list pages, as well as a few on the playground for creating WUs, files, and queries.

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@jeclrsg jeclrsg requested a review from GordonSmith December 17, 2024 18:41
@jeclrsg jeclrsg force-pushed the hpcc-33066-eclwatch-playwright-tests branch from 799127a to 4b736ed Compare December 17, 2024 20:45
@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33066

Jirabot Action Result:
Changing assignee from: [email protected] to: [email protected]
Workflow Transition To: Merge Pending
Additional PR: #19366

@jeclrsg jeclrsg force-pushed the hpcc-33066-eclwatch-playwright-tests branch from 4b736ed to 24fff9a Compare December 17, 2024 21:23
@jeclrsg jeclrsg marked this pull request as draft December 17, 2024 22:05
@jeclrsg jeclrsg force-pushed the hpcc-33066-eclwatch-playwright-tests branch 3 times, most recently from 29c5e51 to 6100f70 Compare January 7, 2025 15:48
@jeclrsg jeclrsg force-pushed the hpcc-33066-eclwatch-playwright-tests branch 6 times, most recently from fa3f8a2 to bc8b7f6 Compare January 15, 2025 15:32
@jeclrsg jeclrsg marked this pull request as ready for review January 15, 2025 15:39
@jeclrsg jeclrsg force-pushed the hpcc-33066-eclwatch-playwright-tests branch 2 times, most recently from bc231e3 to f99210d Compare January 16, 2025 15:06
GordonSmith
GordonSmith reviewed Jan 16, 2025
View reviewed changes
esp/src/eclwatch/ECLPlaygroundWidget.js Outdated
@@ -111,7 +111,7 @@ define([
var logicalCluster = context.targetSelectWidget.selectedTarget();
var submitBtn = registry.byId(context.id + "SubmitBtn");
var publishBtn = registry.byId(context.id + "PublishBtn");
if (logicalCluster.QueriesOnly) {
if (logicalCluster.QueriesOnly || logicalCluster.Type === "roxie") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should really be in a diff PR (especially if the tests are flakey and this doesn't get pulled...)

Copy link
Contributor Author

@jeclrsg jeclrsg Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot about those. That was an attempt at working around the default baremetal install not setting any targets as "QueriesOnly" for the roxie tests creating queries via the playground. But it didn't work anyway (and was replaced with a test that didn't use the UI, but submitted the WUs via comms).

@jeclrsg
HPCC-33066 add more ECL Watch v9 UI tests
59f66b5 
add a few more ECL Watch v9 playwright tests, mostly on the WU, File
and Query list pages, as well as a few on the playground for creating
WUs, files, and queries.

Signed-off-by: Jeremy Clements <[email protected]>
@jeclrsg jeclrsg force-pushed the hpcc-33066-eclwatch-playwright-tests branch from f99210d to 59f66b5 Compare January 16, 2025 16:51
@AttilaVamos
Copy link
Contributor

Why is this playwright test executing every time, opening a web page with list of errors and block the build process when I am building platform in my Ubuntu 22.04 VM?
To continue the build I need to kill the

node /home/ati/HPCC-Platform/esp/src/node_modules/.bin/playwright test

process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GordonSmith GordonSmith GordonSmith left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeclrsg @AttilaVamos @GordonSmith