-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-32810 Add Thor mechanism to capture stacks #19203
base: master
Are you sure you want to change the base?
Conversation
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32810 Jirabot Action Result: |
Via a workunit "Action", trigger the capture of debug info on the manager and workers and associate with the workunit. Signed-off-by: Jake Smith <[email protected]>
21c7c0c
to
2250be4
Compare
common/workunit/workunit.hpp
Outdated
@@ -152,7 +152,8 @@ enum WUAction | |||
WUActionPause = 5, | |||
WUActionPauseNow = 6, | |||
WUActionResume = 7, | |||
WUActionSize = 8 | |||
WUActionSize = 8, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WUActionSize should be last - and should have a comment to that effect..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops. Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakesmith looks good. I only spotted one minor issue.
thorlcr/thorutil/thormisc.cpp
Outdated
@@ -15,6 +15,9 @@ | |||
limitations under the License. | |||
############################################################################## */ | |||
|
|||
#include <fstream> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trivial: Is this still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, removed.
Signed-off-by: Jake Smith <[email protected]>
@ghalliday - please see 2nd commit. |
Via a workunit "Action", trigger the capture of debug info on the manager and workers and associate with the workunit.
Type of change:
Checklist:
Smoketest:
Testing: