Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve macOS DND detection #1540

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Improve macOS DND detection #1540

merged 1 commit into from
Jan 18, 2025

Conversation

hovancik
Copy link
Owner

@hovancik hovancik commented Jan 4, 2025

closed #1402
closes #1513

@hovancik hovancik changed the title Fix macOS DND detection Improve macOS DND detection Jan 18, 2025
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 15.04%. Comparing base (135c3be) to head (79ab66e).
Report is 7 commits behind head on trunk.

Files with missing lines Patch % Lines
app/utils/dndManager.js 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk    #1540      +/-   ##
==========================================
+ Coverage   14.77%   15.04%   +0.27%     
==========================================
  Files          30       30              
  Lines        1970     1974       +4     
==========================================
+ Hits          291      297       +6     
+ Misses       1679     1677       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hovancik hovancik merged commit 343913e into trunk Jan 18, 2025
8 checks passed
@hovancik hovancik deleted the fix/dnd-mac branch January 18, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: npm install not working without distutils [BUG]: Do Not Disturb not working on MacOS
1 participant