-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to vitest #1431
Migrate to vitest #1431
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #1431 +/- ##
===========================================
- Coverage 72.39% 13.71% -58.69%
===========================================
Files 14 27 +13
Lines 355 1845 +1490
===========================================
- Hits 257 253 -4
- Misses 98 1592 +1494 ☔ View full report in Codecov by Sentry. |
Thanks! Will need to find time to check the changes, but Coverage seems to not go through |
I am also getting |
There's nothing wrong with that, electron now supports ESIM and it will be easy to switch in the future |
I fixed the coverage, but there are some differences:
Otherwise, coverage is very similar |
Thanks! I don't really care about the coverage number, I usually only look on difference when having new commits so looks good! |
Issue: #1417
Requirements
node
version specified inpackage.json
was used (ie using nvm).npm install --no-save
).npm run lint
reports no offenses.npm run test
is error-free.Description of the Change
Verification Process
Other information