Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed Belarus flag to white-red-white #1421

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

alehpa
Copy link
Contributor

@alehpa alehpa commented Jan 19, 2024

Issue: No open issue. Have discussion with author beforehand.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • issue was opened to discuss proposed changes before starting implementation. It is important do discuss changes before implementing them (Why should we add it? How should it work? How should it look? Where will it be? ...).
  • during development, node version specified in package.json was used (ie using nvm).
  • package versions and package-lock.json were not changed (npm install --no-save).
  • app version number was not changed.
  • all new code has tests to ensure against regressions.
  • npm run lint reports no offenses.
  • npm run test is error-free.
  • README and CHANGELOG were updated accordingly.
  • after PR is approved, all commits in it are squashed

Description of the Change

Replaced flag of Belarus to national white-red-white.

Verification Process

Checked Svg file - looks great!

Other information

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5289efa) 72.39% compared to head (7b63c1e) 72.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk    #1421   +/-   ##
=======================================
  Coverage   72.39%   72.39%           
=======================================
  Files          14       14           
  Lines         355      355           
=======================================
  Hits          257      257           
  Misses         98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hovancik hovancik merged commit f6317de into hovancik:trunk Jan 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants