Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use code blocks for CLI commands in Readme.md #1416

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Use code blocks for CLI commands in Readme.md #1416

merged 3 commits into from
Jan 8, 2024

Conversation

MRDGH2821
Copy link
Contributor

@MRDGH2821 MRDGH2821 commented Jan 6, 2024

Issue: None

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • issue was opened to discuss proposed changes before starting implementation. It is important do discuss changes before implementing them (Why should we add it? How should it work? How should it look? Where will it be? ...).
  • during development, node version specified in package.json was used (ie using nvm).
  • package versions and package-lock.json were not changed (npm install --no-save).
  • app version number was not changed.
  • all new code has tests to ensure against regressions.
  • npm run lint reports no offenses.
  • npm run test is error-free.
  • README and CHANGELOG were updated accordingly.
  • after PR is approved, all commits in it are squashed

Description of the Change

Use code blocks for CLI commands

Verification Process

Other information

Use code blocks for CLI commands
Add more codeblocks
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41cfee7) 72.39% compared to head (1c66ee2) 72.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk    #1416   +/-   ##
=======================================
  Coverage   72.39%   72.39%           
=======================================
  Files          14       14           
  Lines         355      355           
=======================================
  Hits          257      257           
  Misses         98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Resolve #1416 reviews
@MRDGH2821
Copy link
Contributor Author

Resolved as requested

Copy link
Owner

@hovancik hovancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@hovancik hovancik merged commit 5289efa into hovancik:trunk Jan 8, 2024
5 checks passed
@MRDGH2821
Copy link
Contributor Author

Was it code fence or code block ?🤔
Either way, my intent was to make it easier to copy commands.😄

@hovancik
Copy link
Owner

hovancik commented Jan 9, 2024

No idea :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants