Upgrade pganalyze/pg_query_go and other dependencies #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
oschwald
commented
May 30, 2024
oschwald
commented
- Upgrade to pg_query_go v5
- Update other dependencies
4.2.0 does not work with newer glibc versions, including the version in Ubuntu 24.04. The problem was fixed in pganalyze/pg_query_go#95. Rather than just upgrading to 4.2.3, I thought it would make sense to switch to v5 for Postgres 16 support.
|
@oschwald looks like the test is failing |
The parsing errors have significantly more state now and comparing the whole error is fragile.
|
Thanks. I fixed that by only comparing the error strings, which seems less fragile given the state in |
|
That sounds good to me, thanks @oschwald 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.