Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old React version and import React, ReactDOM and createReactCl… #324

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove old React version and import React, ReactDOM and createReactCl… #324

wants to merge 1 commit into from

Commits on Sep 10, 2019

  1. Remove old React version and import React, ReactDOM and createReactCl… 

    …ass directly from the entry-points

In this commit (af4d9a8) React and ReactDOM where added as dependencies of the project
But it seems that they are not used because no entry-point import them. The React version that is used is the version 0.12.2 that is coming from 2014 and it is loaded as a separate script directly from the HTML templates.
The purpose of this commit is to import React, ReactDOM, and createReactClass from the entry-points and get rid of the old react version.
In this way, the project can be escalated using the new features of React
    @elchininet
    elchininet committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    89266b7 View commit details
    Browse the repository at this point in the history