Migrate Turbo Native helpers to Hotwire Native #691
Merged
+16
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| module Turbo::Native::Navigation | ||
| extend ActiveSupport::Concern | ||
|
|
||
| included do | ||
| helper_method :turbo_native_app? | ||
| helper_method :hotwire_native_app?, :turbo_native_app? |
There was a problem hiding this comment.
It breaks the following patch for Devise:
Quick fix for anyone stumbling across:
class TurboFailureApp < Devise::FailureApp
# Compatibility for Turbo::Native::Navigation
class << self
def helper_method(*names)
end
end
include Turbo::Native::Navigation
# Turbo Native requests that require authentication should return 401s to trigger the login modal
def http_auth?
turbo_native_app? || super
end
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the
turbo_native_app?helper tohotwire_native_app?and changes the user agent check to look for "Hotwire Native".It is backwards compatible with existing Turbo Native apps by aliasing the
turbo_native_app?helper and also checking for "Turbo Native" in the user agent.