-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend composite components from shoelace web components #23
Conversation
@spwoodcock I've just had a thought - I think we could use UnoCSS instead? UnoCSS support the |
Fantastic idea 😁 I was a bit hung up on using Tailwind, but Uno is fantastic & we can use exactly the same syntax as Tailwind if I'm not mistaken. It's a seamless transition! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks great - we just need to migrate to UnoCSS now! 👍
Also, we should probably add a classnames prop, which can be used to add classrooms to specific children of the parent component? I've seen this with other UI libs, and seems good 😄
Completely agree! I think the code for adding extra class names may still be there, but just commented out. If no, it's easy to add back in. I won't have much time to work in this over the next few days, but plan to put in a big shift when I'm back from holidays in May 😄 Ideally we will use this components immediately in the drone tasking manager, with the header probably being the most crucial to start 👍 |
Oh awesome - will take a look! No worries, chat on Monday, hope you have a great weekend! 😄 And that's great, sounds like a plan! 🚀 |
Merging this to make a temp release. We can work on adding UnoCSS & adding a classnames prop in another PR 👍 |
Todo
Testing
pnpm install pnpm run build cd examples/react pnpm install pnpm run dev
View the react toolbar at http://localhost:3000