-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update form by injecting mandatory fields and validate it #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sujanadh
added
enhancement
New feature or request
dependency:osm-fieldwork
Requires updates in osm-fieldwork
labels
Aug 29, 2024
for more information, see https://pre-commit.ci
Updates:decided to return file instead of bytes directly in the response , bytes in the response seems too large and not compatible. |
spwoodcock
approved these changes
Sep 10, 2024
Updated on frontend as well
|
spwoodcock
changed the title
Update form and validate it
Update form by injecting mandatory fields and validate it
Sep 11, 2024
spwoodcock
approved these changes
Sep 11, 2024
Nice coordinated work guys π I just updated osm-fieldwork to 0.16.0 so this should work. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
Related to backend code
dependency:osm-fieldwork
Requires updates in osm-fieldwork
enhancement
New feature or request
frontend
Related to frontend code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
Describe this PR
This PR depends on
osm-fieldwork
in order to injectmandatory_fields
anddigitisation_fields
into a custom form if uploaded.Changes:-
validate-form
used to return a message if the form is valid or not; now it returns form data in bytes along with the message if the form is valid.Frontend Changes:
generate-files
of project creationScreenshots
N/A
Alternative Approaches Considered
Did you attempt any other approaches that are not documented in code?
Review Guide
N/A
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?