Skip to content

Commit

Permalink
Change relevant references from NumPy to array-api-strict
Browse files Browse the repository at this point in the history
And update skips file
  • Loading branch information
honno committed Mar 18, 2024
1 parent f48e4f2 commit 582955c
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 56 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@ jobs:
env:
ARRAY_API_TESTS_MODULE: array_api_strict
run: |
pytest -v -rxXfE --skips-file numpy-skips.txt array_api_tests/
pytest -v -rxXfE --skips-file array-api-strict-skips.txt array_api_tests/
# We also have internal tests that isn't really necessary for adopters
pytest -v -rxXfE meta_tests/
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,9 @@ issues](https://github.com/data-apis/array-api-tests/issues/) to us.

## Running on CI

See our existing [GitHub Actions workflow for
Numpy](https://github.com/data-apis/array-api-tests/blob/master/.github/workflows/numpy.yml)
for an example of using the test suite on CI.
See our existing [GitHub Actions workflow for `array-api-strict`](https://github.com/data-apis/array-api-tests/blob/master/.github/workflows/test.yml)
for an example of using the test suite on CI. Note [`array-api-strict`](https://github.com/data-apis/array-api-strict)
is an implementation of the array API that uses NumPy under the hood.

### Releases

Expand Down
8 changes: 8 additions & 0 deletions array-api-strict-skips.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Known special case issue in NumPy. Not worth working around here
# https://github.com/numpy/numpy/issues/21213
array_api_tests/test_special_cases.py::test_iop[__ipow__(x1_i is -infinity and x2_i > 0 and not (x2_i.is_integer() and x2_i % 2 == 1)) -> +infinity]
array_api_tests/test_special_cases.py::test_iop[__ipow__(x1_i is -0 and x2_i > 0 and not (x2_i.is_integer() and x2_i % 2 == 1)) -> +0]

# The test suite is incorrectly checking sums that have loss of significance
# (https://github.com/data-apis/array-api-tests/issues/168)
array_api_tests/test_statistical_functions.py::test_sum
52 changes: 0 additions & 52 deletions numpy-skips.txt

This file was deleted.

0 comments on commit 582955c

Please sign in to comment.