chore: tidy up lint config #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jharley
commented
Nov 15, 2024
| @@ -86,12 +86,7 @@ func resourceSLOCreate(ctx context.Context, d *schema.ResourceData, meta interfa | |||
| } | |||
|
|
|||
| dataset := d.Get("dataset").(string) | |||
| s, err := expandSLO(d) | |||
There was a problem hiding this comment.
unparam was correct to call out that this function could never return an error (the signature was tying to match a bunch of the other expand* helpers)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #577 +/- ##
==========================================
- Coverage 75.55% 75.49% -0.06%
==========================================
Files 87 87
Lines 7286 7277 -9
==========================================
- Hits 5505 5494 -11
Misses 1429 1429
- Partials 352 354 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unparamfelt a bit extra in tests, so disabled it for test files and then cleaned up all thenolintdirectives