-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle column and derived column imports with slashes in the name #437
Conversation
@@ -61,6 +61,9 @@ func TestClient_InvalidConfig(t *testing.T) { | |||
func TestClient_IsClassic(t *testing.T) { | |||
t.Parallel() | |||
|
|||
// load environment values from a .env, if available | |||
_ = godotenv.Load("../.env") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated, but snuck this in as the test was broken locally
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #437 +/- ##
=======================================
Coverage 83.19% 83.20%
=======================================
Files 62 62
Lines 4178 4168 -10
=======================================
- Hits 3476 3468 -8
+ Misses 549 547 -2
Partials 153 153 ☔ View full report in Codecov by Sentry. |
Some columns and derived columns have slashes in the name. Prior to this change, trying to import either with slashes in the name would result in a message like:
Most (all?) other resources are imported by ID, but this subtle change in splitting does the trick here.