Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): fix Marker Settings flakey test #420

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

jharley
Copy link
Collaborator

@jharley jharley commented Jan 18, 2024

The embedded client's Marker Settings test suite flaked last evening (link) during the nightly smoke test run.

This should hopefully prevent that from happening again in future.

@jharley jharley added the bug label Jan 18, 2024
@jharley jharley requested a review from a team as a code owner January 18, 2024 14:49
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3efb5f4) 80.96% compared to head (ea89d76) 80.96%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #420   +/-   ##
=======================================
  Coverage   80.96%   80.96%           
=======================================
  Files          62       62           
  Lines        4843     4843           
=======================================
  Hits         3921     3921           
  Misses        766      766           
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jharley jharley merged commit 2a84624 into main Jan 18, 2024
2 checks passed
@jharley jharley deleted the jharley.fix-markersettings-client-flake branch January 18, 2024 14:56
jharley added a commit that referenced this pull request Apr 9, 2024
The embedded client's Marker `List` test failed in last evening's CI run
([link](https://github.com/honeycombio/terraform-provider-honeycombio/actions/runs/8608401219/job/23590728118)).

We had a similar issue with Marker Settings `List` (#420) and a similar
treatment fixed it up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants