Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): switch to golangci-lint and fix lints #417

Merged
merged 8 commits into from
Dec 21, 2023

Conversation

jharley
Copy link
Collaborator

@jharley jharley commented Dec 21, 2023

Switches the project to use the more full-featured golangci-lint with a suite of recommended linters coming from the terraform-provider-scaffolding-framework (link) but electing to disable godot and customize some of the lints applied against the SDKv2 portion of the provider.

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (3d30a64) 80.98% compared to head (cac3606) 80.96%.

Files Patch % Lines
honeycombio/provider.go 0.00% 1 Missing ⚠️
internal/provider/burn_alert_resource.go 0.00% 1 Missing ⚠️
internal/provider/provider.go 0.00% 1 Missing ⚠️
internal/provider/trigger_resource.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
- Coverage   80.98%   80.96%   -0.03%     
==========================================
  Files          62       62              
  Lines        4844     4843       -1     
==========================================
- Hits         3923     3921       -2     
- Misses        765      766       +1     
  Partials      156      156              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jharley jharley marked this pull request as ready for review December 21, 2023 19:19
@jharley jharley requested a review from a team as a code owner December 21, 2023 19:19
Copy link
Contributor

@mjayaram mjayaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!!

@jharley jharley merged commit 3efb5f4 into main Dec 21, 2023
2 checks passed
@jharley jharley deleted the jharley.chore-std-linter branch December 21, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants