Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: first pass at moving away from pre-created columns #401

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

jharley
Copy link
Collaborator

@jharley jharley commented Nov 20, 2023

First step toward removing the dependency on scripts/setup-testsuite-dataset and also not being in a position that some failed test runs cause subsequent runs to fail due to conflicts.

In addition to randomly generating strings, the idea is to prefix the things we create with test. and make email addresses in the @example.com domain so that we can in future make use of Sweepers to remove anything starting with test. or in the @example.com domain.

More to improve here, but this was intended to be a "time boxed" first pass.

@jharley jharley requested a review from a team as a code owner November 20, 2023 15:40
Copy link
Contributor

@cewkrupa cewkrupa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love these changes, I think they're gonna make testing much easier!

client/dataset_definitions_test.go Show resolved Hide resolved
@jharley jharley merged commit fc3f20c into main Nov 20, 2023
3 checks passed
@jharley jharley deleted the jharley.fix-test-conflicts-and-deletions branch November 20, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants