Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(honeycombio_board) graph_settings should revert to false when removed #400

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

jharley
Copy link
Collaborator

@jharley jharley commented Nov 18, 2023

When removing a setting from graph_settings the value is not reverted to "false" (the documented default).

During testing #399 was discovered but I believe the fix there is to re-implement the resource in the Plugin Framework.

Initially reported via Honeycomb Support.


@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c9b283) 80.45% compared to head (4aac367) 80.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
+ Coverage   80.45%   80.59%   +0.14%     
==========================================
  Files          62       62              
  Lines        4841     4840       -1     
==========================================
+ Hits         3895     3901       +6     
+ Misses        792      783       -9     
- Partials      154      156       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jharley jharley marked this pull request as ready for review November 20, 2023 13:36
@jharley jharley requested a review from a team as a code owner November 20, 2023 13:36
@jharley jharley merged commit 9198928 into main Nov 20, 2023
3 checks passed
@jharley jharley deleted the jharley.fix-board-graph-settings branch November 20, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants