Add support for 'msteams' recipients #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jharley
commented
Nov 7, 2023
| } | ||
| if v, ok := d.GetOk("detail_filter"); ok { | ||
| rcptFilter = expandRecipientFilter(v.([]interface{})) | ||
| if rcptFilter.Type != matchType { |
There was a problem hiding this comment.
This seems like a fine tradeoff to not have to introduce more complex logic for webhooks and teams being more or less equivalent. We don't fail as fast, but 🤷🏻
jharley
commented
Nov 7, 2023
| @@ -18,9 +18,9 @@ import ( | |||
| "github.com/honeycombio/terraform-provider-honeycombio/internal/models" | |||
| ) | |||
|
|
|||
| func notificationRecipientSchema() schema.SetNestedBlock { | |||
| func notificationRecipientSchema(allowedTypes []client.RecipientType) schema.SetNestedBlock { | |||
There was a problem hiding this comment.
This fixes the bug introduced by the refactor
cewkrupa
approved these changes
Nov 7, 2023
| @@ -18,9 +18,9 @@ import ( | |||
| "github.com/honeycombio/terraform-provider-honeycombio/internal/models" | |||
| ) | |||
|
|
|||
| func notificationRecipientSchema() schema.SetNestedBlock { | |||
| func notificationRecipientSchema(allowedTypes []client.RecipientType) schema.SetNestedBlock { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds supports for
msteamsrecipients.Also fixes a "sneaky bug" where a previous refactor would allow
markertype recipients on Burn Alerts during the validation stage (the API still would reject them).