honeycombio_burn_alert - migrate resource to Plugin Framework #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jharley
commented
Aug 21, 2023
| @@ -57,7 +57,7 @@ func TestAcc_TriggerResourceUpgradeFromVersion014(t *testing.T) { | |||
| { | |||
| ExternalProviders: map[string]resource.ExternalProvider{ | |||
| "honeycombio": { | |||
| VersionConstraint: "~> 0.14", | |||
| VersionConstraint: "~> 0.14.0", | |||
There was a problem hiding this comment.
This was incorrectly testing the upgrade (and pulling in 0.15.2 at the time of the writing). This now properly tests the upgrade from the SDK-based resource
brookesargent
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a similar fashion to the work done for v0.15.0 for
honeycombio_trigger, this migrateshoneycombio_burn_alertto the ~new Plugin Framework to squash the similar set of bugs and annoyances aroundrecipientblocks.Closes #263, #322