Trigger recipient fixes #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brookesargent
approved these changes
May 30, 2023
| @@ -92,6 +92,7 @@ const ( | |||
| PDSeverityERROR PagerDutySeverity = "error" | |||
| PDSeverityWARNING PagerDutySeverity = "warning" | |||
| PDSeverityINFO PagerDutySeverity = "info" | |||
| PDDefaultSeverity = PDSeverityCRITICAL | |||
There was a problem hiding this comment.
Nice add for extra clarity
| } | ||
|
|
||
| func (m notificationRecipientsModifier) PlanModifySet(ctx context.Context, req planmodifier.SetRequest, resp *planmodifier.SetResponse) { | ||
| // Do nothing on resource destroy. |
There was a problem hiding this comment.
thanks for the comments here to explain the logic going on!
| Default: stringdefault.StaticString("critical"), | ||
| Optional: true, | ||
| Computed: true, | ||
| Description: "The severity to set with the PagerDuty notification. If no severity is provided, 'critical' is assumed.", |
LukeCarrier
added a commit
to LukeCarrier/terraform-provider-honeycombio
that referenced
this pull request
Jul 5, 2023
It looks like these missing returns are an oversight from honeycombio#311?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the move of the
honeycombio_triggerresource to the Terraform Plugin Framework (started in #306).In order to support versions of Terraform core older than 1.4.0 (which, is rather "fresh") there is a bit of logic to handle
NullorUnknownvalues of these awkwardly-shaped notification recipients.This also 'bumps' the version of Terraform core used in CI to 1.0.11 (from the old 0.14.x series).