fix: update S3 integration specs to keep up with changing AWS SDK client shape #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbkidd
added
type: maintenance
AWS removed the (private) BUCKET_REGIONS constant, replacing it with a bucket_region_cache accessor on Aws::S3. The .clear method is still also private, but that hasn't stopped us using it in tests so far. ᕕ(ᐛ)ᕗ
Error XML looks different these days. Tests broke when the AWS S3 client got its XML matcher updated[1] in v1.152.3. [1] aws/aws-sdk-ruby@49f4713
robbkidd
force-pushed
the
robb.fix-aws-3-tests
branch
from
0eed44e
to
a7ae9e4
Compare
robbkidd
added
the
status: oncall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
Aws::S3::BUCKET_REGIONSconstant[1] we were using, so switch up to using the accessor methodAws::S3.bucket_region_cache.[1] aws/aws-sdk-ruby@9d55e1f#diff-8232dab0dd0010d16882beee85916c9ec1d9b1573e87fb72f29d6530e2951e9cL78
[2] aws/aws-sdk-ruby@49f4713#diff-38231597d9c2df7aac2db510bd58dbb107727b2e77f0efbf87056075db5e3b31R74