feat: support classic ingest keys #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbkidd
added
status: blocked
version: bump minor
robbkidd
commented
Mar 6, 2024
| @@ -128,9 +128,5 @@ def add_exception_data(span, exception) | |||
| span.add_field("error_backtrace_limit", error_backtrace_limit) | |||
| span.add_field("error_backtrace_total_length", exception.backtrace.length) | |||
| end | |||
|
|
|||
| def classic_write_key?(write_key) | |||
There was a problem hiding this comment.
This was a private method and its only use was to set the classic instance variable on @context.
@context.classic is set now by asking the configuration object directly about its classicness.
robbkidd
commented
Mar 6, 2024
| @@ -43,8 +43,41 @@ | |||
| expect(configuration.write_key).to eq write_key | |||
| end | |||
|
|
|||
| describe "#classic?" do | |||
There was a problem hiding this comment.
Spec the classicness of the various key formats once here.
robbkidd
commented
Mar 6, 2024
| @@ -61,10 +94,12 @@ | |||
|
|
|||
| context "with a classic write key" do | |||
| before do | |||
| configuration.write_key = "c1a551c000d68f9ed1e96432ac1a3380" | |||
| allow(configuration).to receive(:classic?).and_return(true) | |||
There was a problem hiding this comment.
Stub the classic check within "classic" test scopes instead of repeating the matrix of key types all over again.
robbkidd
force-pushed
the
robb.support-classic-ingest-keys
branch
from
92fd533
to
0021bac
Compare
MikeGoldsmith
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
Libhoney.classic_api_key?method and use that method for key checking