Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint: add local dev notes and fix example #233

Merged
merged 4 commits into from
Oct 11, 2023
Merged

maint: add local dev notes and fix example #233

merged 4 commits into from
Oct 11, 2023

Conversation

JamieDanielson
Copy link
Contributor

@JamieDanielson JamieDanielson commented Oct 11, 2023 •
edited
Loading

Which problem is this PR solving?

  • lack of notes on local development
  • dependabot alert on example app (example dep, not a security problem for users of this library)

Short description of the changes

  • Add basic DEVELOPING.md for when occasional maintenance is necessary
  • Replace the datadog/squid image in the rails52 example with ubuntu/squid because the former has been removed from docker
  • Add Gemfile.lock to the .gitignore file - we already intentionally don't check it in, so this just makes it less likely to inadvertently check it in
  • Update puma in rails52 example to quiet dependabot alert

@JamieDanielson JamieDanielson requested a review from a team October 11, 2023 15:34
@JamieDanielson JamieDanielson self-assigned this Oct 11, 2023
@JamieDanielson JamieDanielson added type: maintenance The necessary chores to keep the dust off. type: documentation version: no-bump labels Oct 11, 2023
@JamieDanielson JamieDanielson changed the title maint: add local dev notes and fix example squid image maint: add local dev notes and fix example Oct 11, 2023
@JamieDanielson JamieDanielson merged commit 0a0eafe into main Oct 11, 2023
5 checks passed
@JamieDanielson JamieDanielson deleted the jamie.add-developing branch October 11, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

Assignees

@JamieDanielson JamieDanielson

Labels
type: documentation type: maintenance The necessary chores to keep the dust off. version: no-bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamieDanielson @cartermp