-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation for new integration igloohome #35784
Conversation
- Added first markdown writeup for the integration.
It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
7e42c61
to
c45a4da
Compare
Does anyone know if this is something I can ignore? This PR looks to be correctly targetting the |
📝 WalkthroughWalkthroughThe changes introduce a new documentation file for the igloohome integration with Home Assistant. This documentation details the integration's functionality, setup process, and prerequisites, including the need for an iglooaccess account. It provides a step-by-step guide for users to configure the integration using API credentials and categorizes the integration under sensors, with defined attributes. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Home Assistant
participant igloodeveloper API
User->>Home Assistant: Sign in and input API credentials
Home Assistant->>igloodeveloper API: Request device battery levels
igloodeveloper API-->>Home Assistant: Return battery level updates
Home Assistant-->>User: Display device status
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
- Added first markdown writeup for the integration.
c45a4da
to
d384220
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (3)
source/_integrations/igloohome.markdown (3)
20-22
: Consider adding more account detailsWhile the prerequisite is clear, it would be helpful to mention any specific account requirements (e.g., free vs paid account) or regional availability limitations if any exist.
26-33
: Fix formatting and typos in setup instructionsThere are several issues in the setup instructions:
- Typo: "crendentials" should be "credentials"
- Lists should be surrounded by blank lines
- Remove trailing spaces after "Home Assistant"
Once the account has been created: + - [Sign in](https://access.igloocompany.co/login). - Jump to [API access](https://access.igloocompany.co/api-access). - - Create a set of crendentials with the name `Home Assistant`. + - Create a set of credentials with the name `Home Assistant`. - Copy out the `Client ID` & `Client Secret`. - Add this integration to your Home Assistance instance. - Copy the `Client ID` & `Client Secret` to the respective text fields when prompted by the integration. - The integration will retrieve the devices under your account and update their last known battery level regularly.🧰 Tools
🪛 Markdownlint
29-29: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
27-27: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
33-33
: Consider adding a troubleshooting sectionTo improve user experience, consider adding a troubleshooting section that covers:
- Common setup issues
- API rate limits or connectivity problems
- Steps to take if device updates fail
- How to verify successful integration
Would you like me to provide a template for the troubleshooting section?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
source/_integrations/igloohome.markdown
(1 hunks)
🧰 Additional context used
🪛 Markdownlint
source/_integrations/igloohome.markdown
29-29: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
27-27: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
🔇 Additional comments (2)
source/_integrations/igloohome.markdown (2)
18-18
: LGTM!
Good use of the {% term integration %}
template syntax and proper linking to the API documentation.
7-7
: Review the release version
The ha_release
value of "0.0.1" seems incorrect. For new integrations, this should typically match the upcoming Home Assistant release version.
- Corrected spelling mistake.
- Corrected spelling mistake. - Added blank line between list
Co-authored-by: Joost Lekkerkerker <[email protected]>
Co-authored-by: Joost Lekkerkerker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
source/_integrations/igloohome.markdown (3)
33-33
: Consider clarifying the account activation processThe current wording assumes users know how to activate their iglooaccess account. Consider adding a note about the activation process or linking to relevant documentation.
-Once you have registered and activated your [iglooaccess](https://access.igloocompany.co/register) account: +Once you have registered for an [iglooaccess](https://access.igloocompany.co/register) account and activated it via email verification:
72-72
: Clarify the reload processThe term "reload the config entry" might not be clear to users. Consider providing more specific instructions.
-If you do not have a bridge. Sync the device with the igloohome mobile app, then reload the config entry associated to the device. +If you do not have a bridge. Sync the device with the igloohome mobile app, then go to Settings > Devices & Services, find the igloohome integration, and click the "Reload" button.
77-77
: Add missing newline at end of fileAdd a newline character at the end of the file to comply with markdown standards.
🧰 Tools
🪛 Markdownlint (0.37.0)
77-77: null
Files should end with a single newline character(MD047, single-trailing-newline)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/igloohome.markdown
(1 hunks)
🧰 Additional context used
🪛 Markdownlint (0.37.0)
source/_integrations/igloohome.markdown
77-77: null
Files should end with a single newline character
(MD047, single-trailing-newline)
🔇 Additional comments (4)
source/_integrations/igloohome.markdown (4)
1-15
: LGTM! Front matter is well-structured.
The metadata is complete and accurately reflects the integration's current capabilities.
17-25
: LGTM! Features are clearly documented.
The distinction between bridge and non-bridge functionality is well-explained, and the battery level monitoring features are accurately described.
44-55
: LGTM! Configuration section follows documentation standards.
The configuration parameters are well-documented with clear descriptions.
40-40
:
Fix typo in setup instructions
-Add this integration to your Home Assistant instance.
+Add this integration to your Home Assistant instance.
Likely invalid or redundant comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (1)
source/_integrations/igloohome.markdown (1)
40-40
:⚠️ Potential issueFix typo in setup instructions
There's a typo in the setup instructions.
-Add this integration to your Home Assistant instance. +Add this integration to your Home Assistant instance.
🧹 Nitpick comments (1)
source/_integrations/igloohome.markdown (1)
77-77
: Add newline at end of fileFiles should end with a single newline character.
- Ensure your API credentials have not expired or been revoked. +
🧰 Tools
🪛 Markdownlint (0.37.0)
77-77: null
Files should end with a single newline character(MD047, single-trailing-newline)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/igloohome.markdown
(1 hunks)
🧰 Additional context used
🪛 Markdownlint (0.37.0)
source/_integrations/igloohome.markdown
77-77: null
Files should end with a single newline character
(MD047, single-trailing-newline)
🔇 Additional comments (1)
source/_integrations/igloohome.markdown (1)
17-24
: Well-structured feature documentation!The introduction effectively describes the integration's features, with clear differentiation between bridge and non-bridge owners. The link to the product page provides valuable context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
source/_integrations/igloohome.markdown (3)
46-55
: Minor formatting improvements needed.Please apply these formatting improvements:
{% configuration_basic %} -Client ID: +client_id: description: "Client ID provided by your iglooaccess account." required: true type: string -Client secret: +client_secret: description: "Client Secret provided by your iglooaccess account." required: true type: string {% endconfiguration_basic %}
72-72
: Clarify the reload instructions.The phrase "reload the config entry" might not be clear to all users.
-If you do not have a bridge. Sync the device with the igloohome mobile app, then reload the config entry associated to the device. +If you do not have a bridge: Sync the device with the igloohome mobile app, then go to Settings > Devices & Services, find the igloohome integration, and click the "Reload" button.
77-77
: Add missing newline at end of file.Add a newline character at the end of the file to comply with markdown standards.
- Ensure your API credentials have not expired or been revoked. +
🧰 Tools
🪛 Markdownlint (0.37.0)
77-77: null
Files should end with a single newline character(MD047, single-trailing-newline)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/igloohome.markdown
(1 hunks)
🧰 Additional context used
🪛 Markdownlint (0.37.0)
source/_integrations/igloohome.markdown
77-77: null
Files should end with a single newline character
(MD047, single-trailing-newline)
🔇 Additional comments (2)
source/_integrations/igloohome.markdown (2)
1-15
: LGTM! Frontmatter configuration looks good.The metadata is well-structured with appropriate values for version, IoT class, platforms, and other required fields.
17-25
: LGTM! Clear and well-structured introduction.The introduction effectively:
- Links to the product page
- Clearly differentiates features between bridge and non-bridge owners
- Provides accurate information about battery level updates
@@ -0,0 +1,77 @@ | |||
--- | |||
title: igloohome | |||
description: Integrates igloohome devices via the igloodeveloper API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just this description left and then we're done. :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @silamon , ah okay gotcha. I moved the migrated of the API into the main body rather than this description and mentioned the smart access devices as requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've agreed earlier that the api shouldn't be mentioned to the end customer. So, there should be no mention of the api at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @silamon ,
This is actually question I've left for you.
I've seen multiple integrations (e.g. SmartThings) include the mention of the API. I understand that a non-tech user would not care about the API mention. However, mentioning the API has helpful for me to understand how the integration works on a high-level and the potential implications of it.
If you would still prefer not mentioning the API at all, I can strip it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've opened #36870 to add it back. I've been a bit too strict about this.
- Added mention of igloodeveloper API in main headline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
source/_integrations/igloohome.markdown (3)
17-17
: Fix grammar in features introductionThere's a subject-verb agreement error in the introduction.
-The **igloohome** {% term integration %} grants Home Assistant access to paired [smart access device\(s\)](https://www.igloohome.co/#products) via the igloodeveloper API. The features of this integration includes: +The **igloohome** {% term integration %} grants Home Assistant access to paired [smart access device\(s\)](https://www.igloohome.co/#products) via the igloodeveloper API. The features of this integration include:🧰 Tools
🪛 LanguageTool
[grammar] ~17-~17: Possible subject-verb agreement error.
Context: ...r API. The features of this integration includes: - For [Bridge](https://www.igloohome....(NNS_OF_SINGULAR_AGREEMENT)
24-24
: Add missing article in sync function descriptionAdd "the" before "igloohome mobile app" for proper grammar.
- - Battery levels are updated by using the sync function on igloohome mobile app with the device. + - Battery levels are updated by using the sync function on the igloohome mobile app with the device.🧰 Tools
🪛 LanguageTool
[uncategorized] ~24-~24: You might be missing the article “the” here.
Context: ...e updated by using the sync function on igloohome mobile app with the device. ## Prerequ...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
77-77
: Add newline at end of fileAdd a newline character at the end of the file to comply with markdown standards.
- Ensure your API credentials have not expired or been revoked. \ No newline at end of file + Ensure your API credentials have not expired or been revoked. +🧰 Tools
🪛 Markdownlint (0.37.0)
77-77: null
Files should end with a single newline character(MD047, single-trailing-newline)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/igloohome.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/igloohome.markdown
[grammar] ~17-~17: Possible subject-verb agreement error.
Context: ...r API. The features of this integration includes: - For [Bridge](https://www.igloohome....
(NNS_OF_SINGULAR_AGREEMENT)
[uncategorized] ~24-~24: You might be missing the article “the” here.
Context: ...e updated by using the sync function on igloohome mobile app with the device. ## Prerequ...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
🪛 Markdownlint (0.37.0)
source/_integrations/igloohome.markdown
77-77: null
Files should end with a single newline character
(MD047, single-trailing-newline)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/igloohome.markdown (1)
1-77
: Documentation looks comprehensive and well-structured!The documentation effectively covers all aspects of the integration, including setup, configuration, and troubleshooting. The structure follows Home Assistant's documentation standards, and the content is clear and user-friendly.
🧰 Tools
🪛 LanguageTool
[grammar] ~17-~17: Possible subject-verb agreement error.
Context: ...r API. The features of this integration includes: - For [Bridge](https://www.igloohome....(NNS_OF_SINGULAR_AGREEMENT)
[uncategorized] ~24-~24: You might be missing the article “the” here.
Context: ...e updated by using the sync function on igloohome mobile app with the device. ## Prerequ...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
🪛 Markdownlint (0.37.0)
77-77: null
Files should end with a single newline character(MD047, single-trailing-newline)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
source/_integrations/igloohome.markdown (4)
17-17
: Fix grammar in introductionThere's a subject-verb agreement error in the introduction.
-The **igloohome** {% term integration %} grants Home Assistant access to paired [smart access device\(s\)](https://www.igloohome.co/#products). The features of this integration includes: +The **igloohome** {% term integration %} grants Home Assistant access to paired [smart access device\(s\)](https://www.igloohome.co/#products). The features of this integration include:🧰 Tools
🪛 LanguageTool
[grammar] ~17-~17: Possible subject-verb agreement error.
Context: ...ucts). The features of this integration includes: - For [Bridge](https://www.igloohome....(NNS_OF_SINGULAR_AGREEMENT)
39-39
: Enhance security guidanceWhile the current security note is good, consider expanding it to include best practices for credential management.
-Keep these credentials secure and never share them with others. +Keep these credentials secure and never share them with others. Store them in a password manager and avoid committing them to version control systems or exposing them in logs.
77-77
: Add newline at end of fileFiles should end with a single newline character.
- Ensure your API credentials have not expired or been revoked. +
🧰 Tools
🪛 Markdownlint (0.37.0)
77-77: null
Files should end with a single newline character(MD047, single-trailing-newline)
65-68
: Expand troubleshooting sectionConsider adding more common troubleshooting scenarios:
- Network connectivity issues
- Rate limiting or API throttling
- Steps to check device compatibility
Some generic troubleshooting steps: - Ensure that your subscription is still active. +- Check your network connectivity to igloocompany.co. +- If you encounter API errors, ensure you haven't exceeded rate limits. +- Verify your device's firmware is up to date and compatible.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/igloohome.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/igloohome.markdown
[grammar] ~17-~17: Possible subject-verb agreement error.
Context: ...ucts). The features of this integration includes: - For [Bridge](https://www.igloohome....
(NNS_OF_SINGULAR_AGREEMENT)
🪛 Markdownlint (0.37.0)
source/_integrations/igloohome.markdown
77-77: null
Files should end with a single newline character
(MD047, single-trailing-newline)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
Proposed change
Added markdown documentation for new core integration 'igloohome'
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
New Features
Documentation