Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

picture cards: add person image support to release notes #34176

Conversation

Quentame
Copy link
Member

@Quentame Quentame commented Aug 7, 2024

Proposed change

Add to 2024.8 release notes additions to picture cards home-assistant/frontend#20593

An example and an explanation is available in the code.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • New Features

    • Introduced dynamic image retrieval for picture cards, allowing them to automatically update images based on changes to the associated person entity.
  • Documentation

    • Added a detailed section explaining the new functionality of picture cards and provided examples illustrating the transition from static images to dynamic updates.

@Quentame Quentame requested a review from frenck August 7, 2024 15:00
@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch rc This PR is against the RC branch labels Aug 7, 2024
@home-assistant
Copy link

home-assistant bot commented Aug 7, 2024

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

Copy link
Contributor

coderabbitai bot commented Aug 7, 2024

Warning

Rate limit exceeded

@Quentame has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 15 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 76fb93c and 3123b3c.

Walkthrough

Walkthrough

The recent update enhances picture cards in Home Assistant by enabling them to automatically fetch images from associated person entities. This replaces the earlier model, which relied on static images, allowing for real-time updates that reflect changes in a person's picture. Users now enjoy a streamlined experience, as images remain current without requiring manual intervention.

Changes

Files Change Summary
source/_posts/2024-08-07-release-20248.markdown Added a section titled "Picture cards get image from the person entity," outlining the new feature for dynamic image retrieval from person entities.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant HomeAssistant
    participant PersonEntity
    
    User->>HomeAssistant: Requests picture card
    HomeAssistant->>PersonEntity: Fetch current image
    PersonEntity-->>HomeAssistant: Returns current image
    HomeAssistant-->>User: Displays updated picture card
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 3123b3c
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/66b3a1ab25a642000878e7bf
😎 Deploy Preview https://deploy-preview-34176--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

source/_posts/2024-08-07-release-20248.markdown Outdated Show resolved Hide resolved
source/_posts/2024-08-07-release-20248.markdown Outdated Show resolved Hide resolved
source/_posts/2024-08-07-release-20248.markdown Outdated Show resolved Hide resolved
@Quentame Quentame force-pushed the picture-card/add_person_support_to_release_notes branch from 0aab361 to d150903 Compare August 7, 2024 15:09
Quentame and others added 2 commits August 7, 2024 17:39
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@Quentame Quentame force-pushed the picture-card/add_person_support_to_release_notes branch from d150903 to 9bd9d17 Compare August 7, 2024 15:39
@Quentame Quentame force-pushed the picture-card/add_person_support_to_release_notes branch from f7b42c7 to 76fb93c Compare August 7, 2024 16:31
Co-authored-by: Franck Nijhof <[email protected]>
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks, @Quentame 👍

../Frenck

@frenck frenck merged commit 4827d32 into home-assistant:rc Aug 7, 2024
6 checks passed
@home-assistant home-assistant bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Aug 7, 2024
@Quentame Quentame deleted the picture-card/add_person_support_to_release_notes branch August 7, 2024 16:35
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo rc This PR is against the RC branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants