Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update goodwe.markdown #32679

Closed
wants to merge 1 commit into from
Closed

Conversation

jpnadas
Copy link

@jpnadas jpnadas commented May 10, 2024

updated the documentation to reflect that the goodwe integration is cloud polling.

This is what is shown on the code, and also looking at the rest of the code it indeed polls their API.

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

updated the documentation to reflect that the goodwe integration is cloud polling.
@jpnadas jpnadas requested a review from starkillerOG as a code owner May 10, 2024 09:35
@home-assistant home-assistant bot added the current This PR goes into the current branch label May 10, 2024
Copy link

netlify bot commented May 10, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 6221302
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/663dea6454410300080c7eb4
😎 Deploy Preview https://deploy-preview-32679--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jpnadas
Copy link
Author

jpnadas commented May 10, 2024

it seems like I looked at the wrong repo for the code.

@jpnadas jpnadas closed this May 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant