Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d-integrations: restart HA after adding the integration to the configuration.yaml #32633

Merged

Conversation

c0ffeeca7
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 commented May 8, 2024

Proposed change

d-integrations:

  • add note to restart HA after changing config
  • add related topics
  • rename 'platform' or 'sensor' to 'integration' to streamline terminology
  • add glossary reference to Configuration file

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@c0ffeeca7 c0ffeeca7 requested review from fabaff, a team and frenck as code owners May 8, 2024 06:31
@home-assistant home-assistant bot added the current This PR goes into the current branch label May 8, 2024
Copy link

netlify bot commented May 8, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit f7d360e
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/663c48aef52d0b0008fafa04
😎 Deploy Preview https://deploy-preview-32633--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@c0ffeeca7 c0ffeeca7 marked this pull request as draft May 8, 2024 06:59
@c0ffeeca7 c0ffeeca7 marked this pull request as ready for review May 8, 2024 07:07
@c0ffeeca7 c0ffeeca7 changed the title restart HA after adding the integration to the configuration.yaml d-integrations: restart HA after adding the integration to the configuration.yaml May 8, 2024
@c0ffeeca7 c0ffeeca7 marked this pull request as draft May 8, 2024 08:50
@c0ffeeca7 c0ffeeca7 marked this pull request as ready for review May 8, 2024 09:14
@home-assistant
Copy link

home-assistant bot commented May 8, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 8, 2024 20:15
@frenck frenck marked this pull request as ready for review May 8, 2024 20:27
@home-assistant home-assistant bot requested a review from klaasnicolaas May 8, 2024 20:27
@frenck frenck dismissed klaasnicolaas’s stale review May 9, 2024 20:13

comments addressed

@frenck frenck merged commit 0ea2127 into current May 9, 2024
8 checks passed
@frenck frenck deleted the d-integrations-add-note-to-restart-after-config-change branch May 9, 2024 20:14
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants