Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update character_t.markdown #29412

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Conversation

andreasjacobsen93
Copy link
Contributor

@andreasjacobsen93 andreasjacobsen93 commented Oct 18, 2023

Proposed change

Hopefully a little more clear now that it is the yml files that are referred to

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • I've opened up a PR to add logo's and icons in Brands repository.
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
  • I made a change to the existing documentation and used the current branch.
  • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Hopefully a little more clear now that it is the yml files that are referred to
@home-assistant home-assistant bot added current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 18, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR template is missing in your PR.

Please restore it and fill it out.

Thanks! 👍

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft October 18, 2023 17:54
@andreasjacobsen93 andreasjacobsen93 marked this pull request as ready for review October 19, 2023 14:37
@home-assistant home-assistant bot requested a review from frenck October 19, 2023 14:37
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @andreasjacobsen93 👍

../Frenck

@frenck frenck merged commit 2bbaccf into home-assistant:current Oct 20, 2023
5 checks passed
hareeshmu pushed a commit to hareeshmu/home-assistant.io that referenced this pull request Oct 20, 2023
@andreasjacobsen93 andreasjacobsen93 deleted the patch-6 branch October 20, 2023 20:47
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest!
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants