Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaml.markdown: Link configuration.yaml at first usage #29280

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

reedy
Copy link
Contributor

@reedy reedy commented Oct 9, 2023

Proposed change

Link to configuration.yaml's documentation at first usage

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 9, 2023
Copy link
Member

@klaasnicolaas klaasnicolaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to merge this change, but that's mainly because we don't use text in single quotes as a link.

@home-assistant home-assistant bot marked this pull request as draft October 10, 2023 01:12
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@frenck
Copy link
Member

frenck commented Oct 10, 2023

because we don't use text in single quotes as a link.

I think we do?

Looking at this, I think it is smart and could be applied to any occurrence of configuration.yaml, as it provides help and more context to the ones that need it.

@reedy
Copy link
Contributor Author

reedy commented Oct 10, 2023

because we don't use text in single quotes as a link.

I think we do?

Pretty sure there's a few examples around, and not just what I may have introduced...

Looking at this, I think it is smart and could be applied to any occurrence of configuration.yaml, as it provides help and more context to the ones that need it.

Usually I find if it's a question that one newer person has had, it's a question that many others have had. And things you can do to make onboarding better/easier is always a good thing.

Can we do this a bit more automatically? Like as a build step, doing a string replace?

I suspect there might be a few other similar ones that could be beneficial.

Or would it require at least changing all usages/mentions like this into a template/variable or similar?

@frenck
Copy link
Member

frenck commented Oct 10, 2023

Can we do this a bit more automatically? Like as a build step, doing a string replace?

We should not. It can also be used in code snippets.

@reedy
Copy link
Contributor Author

reedy commented Oct 10, 2023

You mean you don't want to write a backtracking regex to look for whether we're in a code block? ;)

@frenck
Copy link
Member

frenck commented Oct 10, 2023

You mean you don't want to write a backtracking regex to look for whether we're in a code block? ;)

I mean we should just use Markdown and don't rely on magic.

@reedy
Copy link
Contributor Author

reedy commented Oct 10, 2023

Can this be merged then, as is?

@frenck
Copy link
Member

frenck commented Oct 10, 2023

We are awaiting @klaasnicolaas, he left this review. Please have patience, as most people do this in their spare time.

../Frenck

@klaasnicolaas
Copy link
Member

I think we do?

I indeed see that we are applying it on more places, but that is more sporadic. Of course it is a good improvement, but perhaps we need to be consistent in how we handle links and highlighted text... it can be confusing.

But otherwise this PR is good to go for merging.

@frenck
Copy link
Member

frenck commented Oct 10, 2023

Alright, so agreed we can move forward I guess.

That said, this change is invalid nevertheless, as it links to itself 😉

../Frenck

@reedy
Copy link
Contributor Author

reedy commented Oct 10, 2023

Copy paste is hard (sometimes)!

@reedy reedy marked this pull request as ready for review October 10, 2023 19:36
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @reedy 👍

../Frenck

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @reedy 👍

../Frenck

@frenck frenck merged commit 4faba93 into home-assistant:current Oct 10, 2023
@reedy reedy deleted the patch-13 branch October 10, 2023 20:07
@reedy
Copy link
Contributor Author

reedy commented Oct 10, 2023

I'll have a bit of a think about proliferating this a bit more throughout the other doc pages. Though, maybe as I'm making changes to other docs for other reasons, I can include a similar change to this too.

A very quick search suggests there's over 2000 mentions of the string configuration.yaml alone. But as you mention, numerous in code samples as parts of comments etc etc.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest!
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Where to find the configurtion.yaml....
3 participants